cuvs icon indicating copy to clipboard operation
cuvs copied to clipboard

[FEA] ANN bench improvements

Open tfeher opened this issue 1 year ago • 1 comments

During porting the ANN benchmarks from RAFT (#130), a list of potential improvements was created:

  • [ ] clang-tidy: cleanup naming conventions
  • [ ] cleanup/unify logging (including CPU-only builds)
  • [ ] fix/unify create_algo + create_search_param syntax
  • [ ] actualize cuda_stub.hpp for cpu-only builds
  • [ ] make sure there's no direct cuda dependencies in benchmark.hpp
  • [ ] add the memory interconnect info to benchmark context
  • [ ] add command line string which used for running the benchmarking to the benchmark context
  • [ ] add more information about CPU cores and RAM to the benchmark context
  • [ ] etc...

tfeher avatar May 28 '24 10:05 tfeher

Suggestions for improved naming

  • [ ] benchmark name (in build.sh) https://github.com/rapidsai/cuvs/pull/130#discussion_r1619512483
  • [ ] name of index class (in ann_type.hpp) https://github.com/rapidsai/cuvs/pull/130#discussion_r1619515306

tfeher avatar Jun 17 '24 12:06 tfeher