cuvs icon indicating copy to clipboard operation
cuvs copied to clipboard

[REVIEW] fix MG Test bug

Open haiqiang-zhang opened this issue 1 month ago • 2 comments

When Multi-GPU support is disabled via --no-mg, the Multi-GPU tests are still built. This leads to build failures because those tests depend on MG-related components. This PR ensures that MG tests are skipped when Multi-GPU is disabled.

haiqiang-zhang avatar Nov 16 '25 17:11 haiqiang-zhang

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 16 '25 17:11 copy-pr-bot[bot]

/ok to test 12b2f3f

cjnolet avatar Nov 17 '25 17:11 cjnolet

/ok to test c470403

cjnolet avatar Nov 19 '25 21:11 cjnolet

hi @haiqiang-zhang. Can you please use pre-commit per these instructions to reformat the code so it passes the style checker?

Then we can run CI and merge your changes. Thanks!

cjnolet avatar Nov 20 '25 19:11 cjnolet

Hi!

It looks like it has already passed all the style checks:

(cuvs) zhaiqiang@sgs-gpu01:/pub/nfs-data/zhaiqiang/cuvs$ pre-commit run --all-files
check json...............................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for broken symlinks................................................Passed
isort....................................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
mypy.....................................................................Passed
pydocstyle...............................................................Passed
clang-format.............................................................Passed
no-deprecationwarning....................................................Passed
cmake-format.............................................................Passed
- hook id: cmake-format
- duration: 2.93s

Using format file /pub/nfs-data/zhaiqiang/cuvs/cpp/build/_deps/rapids-cmake-src/cmake-format-rapids-cmake.json

cmake-lint...............................................................Passed
- hook id: cmake-lint
- duration: 0.75s

Using format file /pub/nfs-data/zhaiqiang/cuvs/cpp/build/_deps/rapids-cmake-src/cmake-format-rapids-cmake.json

include-check............................................................Passed
cargo-fmt................................................................Passed
codespell................................................................Passed
verify-copyright-cuvs....................................................Passed
verify-copyright-scikit-learn............................................Passed
verify-copyright-cutlass.................................................Passed
verify-copyright-faiss...................................................Passed
verify-alpha-spec........................................................Passed
verify-codeowners........................................................Passed
RAPIDS dependency file generator.........................................Passed
shellcheck...............................................................Passed

The error looks like from version:

Run expected_version="$(python -m dunamai from git --format '{base}')"
ERROR: Expected VERSION file to be "26.02.00", got:
25.12.00
Error: Process completed with exit code 1.

haiqiang-zhang avatar Nov 20 '25 20:11 haiqiang-zhang

Found the problem. I already merged the up-to-date release/25.12. The version problem should be solved

haiqiang-zhang avatar Nov 20 '25 20:11 haiqiang-zhang

/ok to test 5bc29ee

cjnolet avatar Nov 20 '25 21:11 cjnolet

I will close the PR, and reopen a PR forked from release/25.12 . Because the version checker will check the HEAD.

haiqiang-zhang avatar Nov 20 '25 21:11 haiqiang-zhang