cuspatial icon indicating copy to clipboard operation
cuspatial copied to clipboard

[FEA] Define coordinate systems used in lonlat_to_xy_km_coordinates

Open thomcom opened this issue 5 years ago • 7 comments

lonlat_to_xy_km_coordinates doesn't define its transformation exactly. It is just the haversine equation? We should document this.

Similarly, we may want to enable the definition of different coordinate systems when using this function. @zhangjianting what do you think?

thomcom avatar Oct 02 '19 17:10 thomcom

Seconded--this will be very useful for specific coordinate systems (NVIDIA's RAPIDS Fundamentals DLI uses a conversion from WGS84 lat/long to OSGB36 grid coordinates), and it would be helpful to have clarity on what assumptions are being made in this transform.

ChrisMLroy avatar Dec 15 '19 00:12 ChrisMLroy

Sorry that I missed @thomcom comment. This function was a CUDA port of a Java function for Intelligent Transportation applications using surveillance cameras. I do not fully understand the algorithm behind but it could be an approximation of Haversine distance relative to a camera location in lat/lon. @thomcom did you have a chance to talk with John Murray and see how he would like to contribute to projection? Do you want to take a lead on porting John Murray's Numba code in cuSpatial to speed up the support for geographical projections?

zhangjianting avatar Dec 17 '19 02:12 zhangjianting

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

github-actions[bot] avatar Feb 16 '21 20:02 github-actions[bot]

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar Feb 16 '21 20:02 github-actions[bot]

Prompted by the github-actions bot: cuSpatial can definitely still benefit from coordinate system awareness and transforms. We should at least be documenting some bounds on this method's applicability--it's assuming some projection and approximate Cartesian flatness within that projection.

ChrisMLroy avatar Feb 16 '21 20:02 ChrisMLroy

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Mar 18 '21 21:03 github-actions[bot]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar Nov 23 '21 20:11 github-actions[bot]

This was resolved by https://github.com/rapidsai/cuspatial/pull/794

thomcom avatar Dec 01 '22 14:12 thomcom