cuspatial icon indicating copy to clipboard operation
cuspatial copied to clipboard

[BUG] Pairwise linestring distance should return one past the last written output iterator

Open isVoid opened this issue 3 years ago • 3 comments

According to development doc, to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm. Currently, pairwise linestring distance returns void: https://github.com/rapidsai/cuspatial/blob/dbebf67d422104dc47e8ed2ac5a6d2ec75e2e8d0/cpp/include/cuspatial/experimental/linestring_distance.cuh#L61

isVoid avatar Jun 22 '22 00:06 isVoid

to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm.

Not specifically transform, but to match the style of the STL and Thrust in general.

harrism avatar Jun 22 '22 11:06 harrism

to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm.

Not specifically transform, but to match the style of the STL and Thrust in general.

harrism avatar Jun 22 '22 11:06 harrism

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Jul 22 '22 12:07 github-actions[bot]