cuspatial
cuspatial copied to clipboard
[FEA] `polyline` -> `linestring`?
In general, polyline
and linestring
both refers to a data structure that contains multiple points with the line segments that connect the points. Linestring
is standardized in GIS systems through OGC-SFS and provides a lot more relevant search results in google search as compared to search with polyline.
After introduction of #510 there will be two different names of the same concept. I would propose naming polyline
with linestring
in the code base to avoid confusion.
Did "polyline" already exist in the codebase?
Yes, in cpp: https://github.com/rapidsai/cuspatial/blob/8c31c2cad9cc333813848b2e33bb6d0fd884ed6b/cpp/src/spatial/polyline_bounding_box.cu#L57
https://github.com/rapidsai/cuspatial/blob/6a34c21ac13708303cda7c2fb9c49fbb42d04ed5/cpp/include/cuspatial/spatial_join.hpp#L151
in python: https://github.com/rapidsai/cuspatial/blob/92266b6cd88d3283eef45b0a38e712a250f14bdf/python/cuspatial/cuspatial/core/gis.py#L305
https://github.com/rapidsai/cuspatial/blob/92266b6cd88d3283eef45b0a38e712a250f14bdf/python/cuspatial/cuspatial/core/spatial_join.py#L160
Linestring
isn't the first time showing up in the code base either:
https://github.com/rapidsai/cuspatial/blob/92266b6cd88d3283eef45b0a38e712a250f14bdf/python/cuspatial/cuspatial/io/geopandas_adapter.py#L59
This issue has been labeled inactive-30d
due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d
if there is no activity in the next 60 days.
I support this renaming. I think polyline is possibly older, and has moved toward linestring. Primarily I'm pretty sure it just heralds from a slightly different GIS community than ours. Linestring it is, for me.
This issue has been labeled inactive-30d
due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d
if there is no activity in the next 60 days.