cuspatial
cuspatial copied to clipboard
rapidsai
[FEA] Make return value order of quadtree_point_to_nearest_polyline match quadtree_point_in_polygon
In fixing #489 we noticed the following.
cuspatial::quadtree_point_in_polygon returns two values: offsets of polygons, then offsets of points.
https://github.com/rapidsai/cuspatial/blob/6a34c21ac13708303cda7c2fb9c49fbb42d04ed5/cpp/include/cuspatial/spatial_join.hpp#L94-L96
cuspatial::quadtree_point_to_nearest_polyline returns these in the opposite order. (point offset then polyline offset)
https://github.com/rapidsai/cuspatial/blob/6a34c21ac13708303cda7c2fb9c49fbb42d04ed5/cpp/include/cuspatial/spatial_join.hpp#L139-L145
We should make the order match, or adopt structured data with named fields, which could be done as a part of an API refactor to remove dependency on libcudf (#474).
CC @trxcllnt
This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
@trxcllnt would you be able to knock this out while adding the header-only API?
This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.