cuspatial
cuspatial copied to clipboard
[FEA] Drop forced type conversions where appropriate
When the python bindings were written, some or all of the cuda kernels were float
specific. Those have since been updated to proper cudf::column
templates, but this isn't reflected in the python yet. Remove the forced typings in python where appropriate.
This is good because it gives users much more control over their input data, and will also improve performance in any conversion case.
Just did a quick survey, looks like everything except for CubicSpline is using the new normalize_point_columns()
utility function to handle the floating point dtype conversion or upcasting:
https://github.com/rapidsai/cuspatial/blob/81f7d3dcc0bf76be759df1fdb772ed004e29bd80/python/cuspatial/cuspatial/utils/column_utils.py#L8-L13
Does CubicSpline need this as well?
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.
I don't think this is a problem anymore.