cuspatial icon indicating copy to clipboard operation
cuspatial copied to clipboard

List remaining cases after contains, equals, and intersection-only tests are finished.

Open thomcom opened this issue 1 year ago • 0 comments

Disjoint is the opposite of contains for (Point, Point), (Point, Polygon), (Polygon, Point), and (Polygon, MultiPoint). I mistakenly rushed into applying the same reversal to (Polygon, LineString) and (Polygon, LineString), possibly because I trusted my own incorrect docstring too much. I will modify the latter two types to NotImplementedPredicate and correct the docstring to better reflect the correct reversal.

As I write the remaining tests in the test_dispatch (next PR for 23.06) I will first make a list of the unimplemented cases (including the latter two here) and then cross-reference them all with the Binary Predicate Design Doc rules. I'll use that for the rest of the more complicated relationships so I don't stumble down as many rabbit holes.

Originally posted by @thomcom in https://github.com/rapidsai/cuspatial/pull/1016#discussion_r1158586952

thomcom avatar Apr 05 '23 14:04 thomcom