cusignal icon indicating copy to clipboard operation
cusignal copied to clipboard

Add option for smaller dataset in IO notebook

Open charlesbluca opened this issue 2 years ago • 7 comments

Adds the option to use a smaller ~300MB SigMF dataset for the IO examples, as well as code to automatically download / extract the dataset of choice.

Note that there are some failures in the notebook - raised #474 to cover this.

Closes https://github.com/rapidsai/cusignal/issues/472

charlesbluca avatar Apr 05 '22 15:04 charlesbluca

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar May 06 '22 23:05 github-actions[bot]

@awthomp is this good to merge or would you like additional changes?

charlesbluca avatar May 25 '22 16:05 charlesbluca

@charlesbluca LGTM

awthomp avatar May 25 '22 16:05 awthomp

Ah I just noticed that I should rerun the cells with ValueErrors now that the pinned buffer issues have been resolved - will do that then this should be good to merge

charlesbluca avatar May 25 '22 16:05 charlesbluca

Sorry for the delay - this should be good to merge now

charlesbluca avatar May 25 '22 21:05 charlesbluca

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Jun 24 '22 22:06 github-actions[bot]

@gpucibot merge

awthomp avatar Nov 21 '22 20:11 awthomp