cusignal icon indicating copy to clipboard operation
cusignal copied to clipboard

Fix complex type bug with correlate

Open mnicely opened this issue 3 years ago • 7 comments

Found a bug with correlate 1D + complex data types.

mnicely avatar May 26 '21 19:05 mnicely

rerun tests

awthomp avatar May 27 '21 13:05 awthomp

rerun tests

awthomp avatar Jun 01 '21 20:06 awthomp

@ajschmidt8 -- looks like CI is failing for the centos7 test that isn't related to this PR. Can we get this merged?

awthomp avatar Jun 02 '21 12:06 awthomp

@awthomp I'm seeing a lot of failures (see screenshot) related to the test_convolution.py file which was touched in this PR. can you double-check the tests to ensure that they are correct?

image

ajschmidt8 avatar Jun 02 '21 15:06 ajschmidt8

D'oh! I missed this in the "Details" of the failed test log. My bad! I'll work with @mnicely to get this test passing before merge.

awthomp avatar Jun 03 '21 00:06 awthomp

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

github-actions[bot] avatar Nov 23 '21 20:11 github-actions[bot]

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Nov 23 '21 20:11 github-actions[bot]