cuml icon indicating copy to clipboard operation
cuml copied to clipboard

Move cumlprims_mg into cuML

Open dantegd opened this issue 3 weeks ago • 1 comments

This PR removes the dependency on the separate cumlprims_mg library by moving all of its code directly into cuML. The cumlprims_mg library provided multi-node multi-GPU (MNMG) primitives used by several cuML algorithms. By inlining this code, we simplify the build process, reduce external dependencies, and make it easier to maintain the MNMG functionality alongside the algorithms that use it.

Changes:

  • New (i.e. moved files from cumlprims_mg) source files added to cuml/cpp/src_prims/opg/
  • Build system changes
    • Added new source files to cuml_objs target in cpp/CMakeLists.txt
    • Removed cumlprims_mg::cumlprims_mg from link libraries
    • Deleted cmake/thirdparty/get_cumlprims_mg.cmake
    • Removed ENABLE_CUMLPRIMS_MG and CUML_EXCLUDE_CUMLPRIMS_MG_FROM_ALL CMake options
  • Dependency/configuration updates
    • Updated dependencies.yaml to remove libcumlprims
    • Updated all conda environment YAML files
    • Updated conda recipes (libcuml/recipe.yaml, cuml/recipe.yaml)
    • Updated CI scripts (build_wheel_libcuml.sh, build_wheel_cuml.sh)
    • Updated ci/release/update-version.sh
  • Python changes
    • Updated Cython declarations in opg_data_utils_mg.pxd
    • Updated python/libcuml/CMakeLists.txt and python/cuml/CMakeLists.txt
    • Updated libcuml/load.py to no longer load libcumlprims_mg.so
    • Updated linkage tests
  • Documentation updates
    • Updated BUILD.md, cpp/README.md, python/cuml/README.md

dantegd avatar Dec 09 '25 21:12 dantegd

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Dec 09 '25 21:12 copy-pr-bot[bot]

/ok to test 3fa42b7d2a65319d24929eeb1e90d99351e6e817

divyegala avatar Dec 17 '25 21:12 divyegala

/ok to test

dantegd avatar Dec 17 '25 22:12 dantegd

/ok to test

dantegd avatar Dec 17 '25 23:12 dantegd