cuml icon indicating copy to clipboard operation
cuml copied to clipboard

Prepare cuml for removal of deprecated raft apis

Open aamijar opened this issue 1 month ago • 1 comments

Resolves https://github.com/rapidsai/cuml/issues/7554, Depends on https://github.com/rapidsai/cuvs/pull/1610 (CI won't pass until this is merged)

What does this PR do?

  1. Removes lingering unused raft headers that will be deprecated such as #include <raft/spatial/knn/knn.cuh>, #include <raft/distance/distance.cuh>, etc.
  2. Updates to raft::memory_type_from_pointer instead of the deprecated raft::spatial::knn::detail::utils::pointer_residency.
  3. Removes metric_processor from knn.hpp and knn.cu which is not needed since cuvs handles it internally.
  4. Uses build_dendrogram_host from cuvs instead of raft.

aamijar avatar Dec 03 '25 01:12 aamijar

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Dec 03 '25 01:12 copy-pr-bot[bot]

I've updated the PR so that pre and post processing code should functionally be the same. The goal is to remove the dependency on processing.cuh from raft which was implicitly included in #include <raft/spatial/knn/ann.cuh>. So I've taken the bits of code from processing.cuh as put it in knn.cu directly.

aamijar avatar Dec 14 '25 07:12 aamijar

/merge

aamijar avatar Dec 15 '25 19:12 aamijar