cuml icon indicating copy to clipboard operation
cuml copied to clipboard

[REVIEW] Unpin `dask` and `distributed` for development

Open galipremsagar opened this issue 2 years ago • 8 comments

This PR unpins dask & distributed for 22.10 development.

xref: https://github.com/rapidsai/cudf/pull/11492

galipremsagar avatar Aug 08 '22 15:08 galipremsagar

rerun tests

galipremsagar avatar Aug 09 '22 13:08 galipremsagar

rerun tests

galipremsagar avatar Aug 09 '22 23:08 galipremsagar

rerun tests

ajschmidt8 avatar Aug 11 '22 15:08 ajschmidt8

rerun tests

galipremsagar avatar Aug 17 '22 17:08 galipremsagar

@dantegd | @cjnolet Can someone take a look at cuml dask-related test failures?, this seems to be blocking.

galipremsagar avatar Aug 26 '22 15:08 galipremsagar

rerun tests

dantegd avatar Aug 31 '22 18:08 dantegd

Seems like there are pytest failures:

[Test Result](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/) (5 failures / +5)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[None]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_None_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[first]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_first_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[drop2]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_drop2_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_drop_idx_first](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_drop_idx_first/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_drop_one_of_each](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_drop_one_of_each/)

galipremsagar avatar Sep 01 '22 11:09 galipremsagar

rerun tests

galipremsagar avatar Sep 21 '22 18:09 galipremsagar

rerun tests

quasiben avatar Sep 28 '22 17:09 quasiben

@quasiben @galipremsagar working on a small fix for the CI tests errors that are happening, will push them shortly

dantegd avatar Sep 28 '22 18:09 dantegd

Tagging this PR with DONOT MERGE because we are waiting on a new dask release 2022.9.2 which will be out tomorrow.

galipremsagar avatar Sep 30 '22 00:09 galipremsagar

rerun tests

galipremsagar avatar Oct 02 '22 15:10 galipremsagar

@gpucibot merge

cjnolet avatar Oct 04 '22 02:10 cjnolet

Codecov Report

Base: 79.35% // Head: 79.35% // No change to project coverage :thumbsup:

Coverage data is based on head (5750683) compared to base (96da84c). Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10    #4859   +/-   ##
=============================================
  Coverage         79.35%   79.35%           
=============================================
  Files               181      181           
  Lines             11540    11540           
=============================================
  Hits               9158     9158           
  Misses             2382     2382           
Flag Coverage Δ
dask 46.02% <ø> (ø)
non-dask 68.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 04 '22 03:10 codecov-commenter