cuml icon indicating copy to clipboard operation
cuml copied to clipboard

Transforms RandomForest estimators non-consecutive labels to consecutive labels where appropriate

Open VamsiTallam95 opened this issue 3 years ago • 11 comments

This PR closes #4478 by transforming non-consecutive labels outside of [0,n) to consecutive labels inside [0,n) similar to what Scikit-learn does under the hood.

Closes #691

VamsiTallam95 avatar Jun 17 '22 02:06 VamsiTallam95

rerun tests

ayushdg avatar Jun 29 '22 23:06 ayushdg

rerun tests

VamsiTallam95 avatar Jul 10 '22 01:07 VamsiTallam95

rerun tests

VamsiTallam95 avatar Jul 12 '22 18:07 VamsiTallam95

rerun tests

VamsiTallam95 avatar Jul 14 '22 21:07 VamsiTallam95

Codecov Report

Merging #4780 (8cd8d3a) into branch-22.08 (b26fe7e) will increase coverage by 0.00%. The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #4780   +/-   ##
=============================================
  Coverage         77.62%   77.62%           
=============================================
  Files               180      180           
  Lines             11382    11384    +2     
=============================================
+ Hits               8835     8837    +2     
  Misses             2547     2547           
Flag Coverage Δ
dask 45.52% <ø> (+<0.01%) :arrow_up:
non-dask 67.26% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/metrics/__init__.py 100.00% <0.00%> (ø)
python/cuml/metrics/cluster/__init__.py 100.00% <0.00%> (ø)
python/cuml/thirdparty_adapters/adapters.py 91.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b26fe7e...8cd8d3a. Read the comment docs.

codecov-commenter avatar Jul 15 '22 00:07 codecov-commenter

Is this ready for another round of reviews?

beckernick avatar Jul 25 '22 22:07 beckernick

Its ready!

VamsiTallam95 avatar Jul 26 '22 19:07 VamsiTallam95

rerun tests

lowener avatar Aug 31 '22 21:08 lowener

rerun tests

lowener avatar Sep 01 '22 10:09 lowener

Changing the title before merging, as this PR only applies this change to random forest models.

beckernick avatar Sep 08 '22 13:09 beckernick

This will also close https://github.com/rapidsai/cuml/issues/691

beckernick avatar Sep 12 '22 14:09 beckernick

@gpucibot merge

dantegd avatar Sep 29 '22 20:09 dantegd