cuml icon indicating copy to clipboard operation
cuml copied to clipboard

`PowerTransformer`, `QuantileTransformer` and `KernelCenterer`

Open viclafargue opened this issue 2 years ago • 6 comments

Closes #4622

viclafargue avatar May 24 '22 14:05 viclafargue

Can you rebase or merge the latest changes? It seems that we're getting tagged to review code changes that were merged in previous PRs.

ajschmidt8 avatar Jun 01 '22 20:06 ajschmidt8

Can you rebase or merge the latest changes? It seems that we're getting tagged to review code changes that were merged in previous PRs.

Sorry for that. branch-22.08 appear to be unsynced. I think that it is what is causing the issue. I think it's on its way in #4751.

viclafargue avatar Jun 02 '22 08:06 viclafargue

@viclafargue, no problem. I've just resolved the conflicts in that PR and merged it. The branches should be in sync now.

ajschmidt8 avatar Jun 03 '22 14:06 ajschmidt8

rerun tests

viclafargue avatar Jun 22 '22 16:06 viclafargue

This will also close https://github.com/rapidsai/cuml/issues/2035 , right?

beckernick avatar Jun 29 '22 14:06 beckernick

This will also close #2035 , right?

Thanks for noticing me of this issue. The version of the QuantileTransformer in this PR does operations in a similar fashion to sklearn but simply uses cuPy instead for acceleration. It looks like the issue you are pointing to is about getting optimal performance through the use of C++ code that has already been written. I think that we should let this issue opene and keep the QuantileTransformer in this PR as temporary solution that can be replaced in the longer term.

viclafargue avatar Jun 29 '22 14:06 viclafargue

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Aug 28 '22 11:08 github-actions[bot]

Codecov Report

Base: 78.02% // Head: 79.68% // Increases project coverage by +1.65% :tada:

Coverage data is based on head (4753ec4) compared to base (7a0ab85). Patch coverage: 93.79% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.10    #4755      +/-   ##
================================================
+ Coverage         78.02%   79.68%   +1.65%     
================================================
  Files               180      180              
  Lines             11385    11457      +72     
================================================
+ Hits               8883     9129     +246     
+ Misses             2502     2328     -174     
Flag Coverage Δ
dask 46.24% <39.31%> (+0.02%) :arrow_up:
non-dask 68.99% <93.79%> (+1.72%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/cuml/_thirdparty/sklearn/utils/validation.py 72.54% <ø> (+5.88%) :arrow_up:
python/cuml/preprocessing/__init__.py 100.00% <ø> (ø)
python/cuml/common/array.py 95.10% <85.10%> (-2.88%) :arrow_down:
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 90.01% <96.92%> (+21.09%) :arrow_up:
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <100.00%> (ø)
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 57.64% <100.00%> (+0.50%) :arrow_up:
python/cuml/cluster/__init__.py 100.00% <100.00%> (ø)
python/cuml/metrics/__init__.py 100.00% <100.00%> (ø)
python/cuml/testing/test_preproc_utils.py 87.19% <100.00%> (+1.77%) :arrow_up:
python/cuml/thirdparty_adapters/adapters.py 91.54% <100.00%> (+0.05%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 31 '22 20:08 codecov-commenter

@gpucibot merge

dantegd avatar Sep 11 '22 19:09 dantegd