cuml
cuml copied to clipboard
rapidsai
SparseRandomProjection improvement
@viclafargue just checking the status on this PR. Are these changes still being worked or need any reviews?
@viclafargue just checking the status on this PR. Are these changes still being worked or need any reviews?
Thanks for reminding me of this. I think that since CI update these changes can be worked on again. I'll work on merging those, a review would then be welcome :) . Thanks
Codecov Report
:exclamation: No coverage uploaded for pull request base (
branch-21.12@dd7cbf4). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## branch-21.12 #3899 +/- ##
===============================================
Coverage ? 86.07%
===============================================
Files ? 231
Lines ? 18699
Branches ? 0
===============================================
Hits ? 16095
Misses ? 2604
Partials ? 0
| Flag | Coverage Δ | |
|---|---|---|
| dask | 47.01% <0.00%> (?) |
|
| non-dask | 78.76% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update dd7cbf4...e4d4754. Read the comment docs.
@viclafargue, is this PR still relevant? I see the ops-codeowners were requested for review, but it seems like this PR needs a bit of clean-up before it's reviewable (i.e. updating base branch, merging the latest changes, letting CI run, etc).
I think this PR is still relevant, but it wasn't targeted for the right branch. I think that's what triggered the ops-codeowners group to be set as reviewer. Sorry for the inconvenience.