cugraph icon indicating copy to clipboard operation
cugraph copied to clipboard

[FEA] Support Seed Retention for Sampling with Renumbering

Open alexbarghi-nv opened this issue 1 year ago • 2 comments

Exposes the ability to retain seeds even if they have no outgoing edges (and therefore are not sampled). Required to fix the current bug in cuGraph-PyG involving batch size and dropping seeds.

Currently, this functionality can't be exposed through the MG Python API (#4358) but exposing it through the pylibcugraph API is sufficient to resolve this issue. This PR does expose it through the SG Python API.

alexbarghi-nv avatar Apr 17 '24 19:04 alexbarghi-nv

LGTM Shouldn't we add C++ test for the added option?

This is not an added C++ option, it already existed. It was never exposed/used through the C API. I believe (didn't exhaustively look) that it is already tested in sampling_post_processing_test.cu.

ChuckHastings avatar May 06 '24 19:05 ChuckHastings

/merge

alexbarghi-nv avatar May 07 '24 17:05 alexbarghi-nv