cugraph icon indicating copy to clipboard operation
cugraph copied to clipboard

Mark kernels as internal

Open robertmaynard opened this issue 1 year ago • 1 comments

Downstream consumers of static built versions of RAPIDS C++ projects have encountered runtime issues due to multiple instances of the same kernel existing in different DSOs.

To resolve this issue we need to ensure that all CUDA kernels in all RAPIDS libraries need to be have internal linkage ( static for projects using whole compilation, attribute((visibility("hidden"))) for header libraries / separable compilation ).

This updates all cugraph kernels to have internal linkage, and adds a CI job to verify that no new kernels are added with external linkage.

robertmaynard avatar Jan 17 '24 16:01 robertmaynard

/ok to test

naimnv avatar Feb 21 '24 18:02 naimnv

/merge

robertmaynard avatar Mar 11 '24 17:03 robertmaynard

/merge

ChuckHastings avatar Mar 11 '24 17:03 ChuckHastings