cugraph icon indicating copy to clipboard operation
cugraph copied to clipboard

suppress expansion of unused raft spectral templates

Open ChuckHastings opened this issue 3 years ago • 1 comments

Closes #2678

raft updated some k-means logic and dramatically increased the compile time of our spectral clustering implementation. This PR adds an include that will suppress the expansion of templates that we are not using.

ChuckHastings avatar Sep 19 '22 20:09 ChuckHastings

rerun tests

ChuckHastings avatar Sep 20 '22 14:09 ChuckHastings

rerun tests

ChuckHastings avatar Sep 26 '22 18:09 ChuckHastings

@vyasr do you have any ideas as to why this would still be failing when libraft-distance is installed as a dependency of cugraph/pylibcugraph? I'm scratching my head a little bit.

cjnolet avatar Sep 26 '22 22:09 cjnolet

@cjnolet @ChuckHastings If you're pulling libraft-distances then I believe the target that you should be linking to is raft::raft_distance_lib instance of raft::distance.

vyasr avatar Sep 27 '22 01:09 vyasr

@cjnolet @ChuckHastings If you're pulling libraft-distances then I believe the target that you should be linking to is raft::raft_distance_lib instance of raft::distance.

Trying that now, thanks!

ChuckHastings avatar Sep 27 '22 03:09 ChuckHastings

Hmm apparently not the issue. Can you reproduce this locally? I can give that a shot if you haven't been able to.

vyasr avatar Sep 27 '22 15:09 vyasr

Corey fixed this in #2739 , we'll merge that PR instead.

ChuckHastings avatar Sep 27 '22 16:09 ChuckHastings

Ahhh I think I see the issue.

vyasr avatar Sep 27 '22 17:09 vyasr