cugraph icon indicating copy to clipboard operation
cugraph copied to clipboard

[ENH] Python tests should have a shared set of fixtures

Open rlratzel opened this issue 4 years ago • 5 comments

Many of the tests do very similar setup steps, including iterating over a set of datasets, creating a specific graph type, creating a specif Nx graph type, running an algo and checking/comparing results. The steps prior to running the algo are almost identical across most tests, yet each test has its own set of fixtures.

The shared util file defines the dataset params (which is good), but the actual fixtures could be shared as well. This should allow for a great deal of cleanup when applied to all python tests.

  • Add/update a fixture for reading in datasets and returning a graph object
    • For use with all datasets, subset of datasets, etc.
    • Have pytest options for which datasets to run
    • Add this to a shared “fixtures” module, configured to scope “session”
  • Add/update a fixture for returning a Nx graph object
    • Calls fixture above to read in dataset and return cugraph obj
    • Add this to a shared “fixtures” module, configured to scope “session”
  • Add/update a fixture for per-algo Nx runs with params for comparisons
    • Unique to a particular algo comparison (scope=”module”)

rlratzel avatar Jan 21 '21 01:01 rlratzel

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Mar 03 '21 20:03 github-actions[bot]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar May 02 '21 05:05 github-actions[bot]

This is on-hold but should be addressed in upcoming refactorings.

rlratzel avatar Jul 28 '21 15:07 rlratzel

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar Nov 23 '21 20:11 github-actions[bot]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Dec 23 '21 21:12 github-actions[bot]

Some of the proposed changes mentioned here have either been done for a subset of tests or are still being planned. Since this issue is relatively stale, we'll close it and re-open as one or more smaller issues when we're closer to continuing work on these changes.

rlratzel avatar Apr 24 '24 19:04 rlratzel