cudf
cudf copied to clipboard
[FEA] Resolve what to do with semi-redundant fields in cuIO table_metadata
This PR (https://github.com/rapidsai/cudf/pull/6318) adds a new field to the table_metadata struct, schema_info, which contains the column names for the entire hierarchy of returned columns, not just the root columns.
This is semi-redundant with the existing column_names but we decided to avoid breaking any existing external dependencies that use column_names for 0.16.
We should decide if they should be folded together (likely, column_names would just use the new data structure)
@devavret this seems related to schema changes
Thanks for pointing to the issue. I observed this but didn't know its already filed.
This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.
still relevant
From some work in the JSON reader, it looks like we can remove column_names, as the same names can be accessed in schema_info.
It should just be a matter of switching to the new member in Cython and in the C++ tests.
@galipremsagar any concerns with gradual switch to schema_info?
No concerns from my side, SGTM 👍