cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Remove `hostdevice_vector::element` due to unnecessary synchronization (Part 2 of miss-sync)

Open JigaoLuo opened this issue 8 months ago • 1 comments

Description

For issue #18967, this PR is one part of merging the PR Draft #18968. In this PR, hostdevice_vector::element is removed due to its internal cudaMemcpy into host pageable memory. Also, the only call in it is replaced manually.

@mhaseeb123: Adding a DO NOT MERGE label for now as the removed stuff is needed to reproduce the compiler segfault issue: #18980

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

JigaoLuo avatar Jun 04 '25 21:06 JigaoLuo

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Jun 04 '25 21:06 copy-pr-bot[bot]

Hi @mhaseeb123 , just wanted to check if any update on the bug that’s currently blocking the merge of this pull request? Thanks!

JigaoLuo avatar Jul 18 '25 05:07 JigaoLuo

Hi @mhaseeb123 , just wanted to check if any update on the bug that’s currently blocking the merge of this pull request? Thanks!

Unfortunately, I don't see any updates on the page. @GregoryKimball @vuule should we just move ahead with this PR and refer NVBug to use libcudf branch-25.08 (before this PR's commit) to reproduce the bug.

mhaseeb123 avatar Jul 22 '25 17:07 mhaseeb123

Thanks for the update! I’m happy to either leave it as is (for NVbug bookkeeping) or proceed with the merge—whichever option aligns with what we discussed.

JigaoLuo avatar Jul 22 '25 18:07 JigaoLuo

I would be okay with letting this PR move along. Should not be too hard to recreate the repro even without the element function.

vuule avatar Jul 22 '25 22:07 vuule

Alrighty then, let's review this and merge

mhaseeb123 avatar Jul 22 '25 22:07 mhaseeb123

/ok to test 8dc770e

mhaseeb123 avatar Jul 22 '25 22:07 mhaseeb123

Thanks for approving it and updating the PR title!

JigaoLuo avatar Jul 23 '25 07:07 JigaoLuo

/ok to test 729a8e9

mhaseeb123 avatar Jul 23 '25 19:07 mhaseeb123

/merge

mhaseeb123 avatar Jul 23 '25 22:07 mhaseeb123