cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Changed JITIFY Upstream

Open lamarrr opened this issue 9 months ago • 3 comments

Description

This merge request changes our upstream for JITIFY2 from the RAPIDSAI source to the NVIDIA source. It also introduces a new dependency for JITIFY2 (CUDA 12.* ) : Libnvjitlink

Depends on https://github.com/NVIDIA/jitify/pull/138 and https://github.com/NVIDIA/jitify/pull/131

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

lamarrr avatar Feb 24 '25 16:02 lamarrr

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Feb 24 '25 16:02 copy-pr-bot[bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar May 29 '25 17:05 copy-pr-bot[bot]

Presently blocked by a change to the preprocessing method in JITIFY. The new method loads all included headers even if they are guarded by macros that disable them.

It is presently choking on this header from Thrust.

#define __THRUST_HOST_SYSTEM_EXECUTION_POLICY_HEADER <__THRUST_HOST_SYSTEM_ROOT/execution_policy.h>
#include __THRUST_HOST_SYSTEM_EXECUTION_POLICY_HEADER
#undef __THRUST_HOST_SYSTEM_EXECUTION_POLICY_HEADER

For context: Thrust isn't included in RTC compiled code, and it is disabled by a macro, but with this change, the header is included regardless with missing macros. Making the _THRUST_HOST_SYSTEM_ROOT expansion fail.

lamarrr avatar May 29 '25 17:05 lamarrr

succeeded by https://github.com/rapidsai/cudf/pull/19561

lamarrr avatar Aug 01 '25 12:08 lamarrr