cudf icon indicating copy to clipboard operation
cudf copied to clipboard

JSON tree algorithms refactor I: CSR data structure for column tree

Open shrshi opened this issue 1 year ago • 10 comments
trafficstars

Description

Part of #15903.

  1. Introduces the Compressed Sparse Row (CSR) format to store the adjacency information of the column tree.
  2. Analogous to reduce_to_column_tree, reduce_to_column_tree_csr reduces node tree representation to column tree stored in CSR format.

TODO:

  • [x] Correctness test

Checklist

  • [X] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.

shrshi avatar Jun 11 '24 20:06 shrshi

Question: Is this ready for review? Or still WIP?

ttnghia avatar Jun 25 '24 17:06 ttnghia

Question: Is this ready for review? Or still WIP?

Sorry, forgot to update the title. It's ready for review.

shrshi avatar Jun 25 '24 18:06 shrshi

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Jun 28 '24 17:06 copy-pr-bot[bot]

/ok to test

shrshi avatar Jun 28 '24 17:06 shrshi

/ok to test

shrshi avatar Jul 15 '24 19:07 shrshi

@ttnghia would you please share your feedback on this PR?

GregoryKimball avatar Jul 16 '24 17:07 GregoryKimball

/ok to test

shrshi avatar Jul 30 '24 23:07 shrshi

/ok to test

shrshi avatar Jul 31 '24 05:07 shrshi

/ok to test

shrshi avatar Jul 31 '24 05:07 shrshi

/ok to test

shrshi avatar Jul 31 '24 18:07 shrshi

/ok to test

shrshi avatar Sep 06 '24 23:09 shrshi

This looks fine. I didn't see any test or performance regressions or improvements with this patch.

AFAIK the new path is not (yet) use by default.

vuule avatar Sep 10 '24 05:09 vuule

/ok to test

shrshi avatar Sep 17 '24 18:09 shrshi

/ok to test

shrshi avatar Sep 20 '24 21:09 shrshi

/ok to test

shrshi avatar Sep 23 '24 17:09 shrshi

/ok to test

shrshi avatar Sep 23 '24 17:09 shrshi

/ok to test

shrshi avatar Sep 23 '24 18:09 shrshi

/ok to test

shrshi avatar Sep 23 '24 23:09 shrshi

/ok to test

shrshi avatar Sep 24 '24 00:09 shrshi

/ok to test

shrshi avatar Sep 24 '24 17:09 shrshi

/ok to test

ttnghia avatar Sep 24 '24 21:09 ttnghia

/okay to test

galipremsagar avatar Sep 24 '24 23:09 galipremsagar

/ok to test

shrshi avatar Sep 25 '24 02:09 shrshi

/ok to test

karthikeyann avatar Sep 25 '24 15:09 karthikeyann

/merge

shrshi avatar Sep 25 '24 19:09 shrshi