cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Published 20 hours ago • verified publisher icon rapidsai

Migrate string replace.pxd to pylibcudf

Open lithomas1 opened this issue 1 year ago • 1 comments
trafficstars

Description

Checklist

  • [ ] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.

lithomas1 avatar May 23 '24 16:05 lithomas1

probably should go in after https://github.com/rapidsai/cudf/pull/15503

lithomas1 avatar May 23 '24 19:05 lithomas1

I'm holding off on a second review until #15503 is merged, but in the meantime could you add a short PR description please?

vyasr avatar May 28 '24 17:05 vyasr

Lets wait for #15898

lithomas1 avatar May 31 '24 15:05 lithomas1

#15898 is merged

vyasr avatar Jun 03 '24 19:06 vyasr

OK, this is re-sync'ed and ready for re-review.

lithomas1 avatar Jun 03 '24 22:06 lithomas1

/merge

lithomas1 avatar Jun 05 '24 15:06 lithomas1