cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Clean up nvtx macros

Open PointKernel opened this issue 1 year ago • 3 comments

Description

This PR includes several cleanups for the cudf nvtx wrappers:

  • Removed the unused NVTX3_FUNC_RANGE macro
  • Fixed a typo in the doc
  • Added an example in the cudf::thread_range doc
  • Updated the NVTX section in the developer guide doc

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

PointKernel avatar Feb 13 '24 20:02 PointKernel

Notes: Users cannot specify the function name with CUDF_FUNC_RANGE: Screenshot from 2024-02-13 11-51-04 Custom ranges can be done via cudf::thread_range, i.e. hash_join::inner_join: Screenshot from 2024-02-13 11-49-56

PointKernel avatar Feb 13 '24 20:02 PointKernel

You could always just call nvtxRangePushA(custom-name)' and 'nvtxRangePop()

davidwendt avatar Feb 13 '24 20:02 davidwendt

Also, this reminds me that the vendored version of nvtx in cudf is wildly out of date and should be removed. See https://github.com/rapidsai/cudf/issues/6476

jrhemstad avatar Feb 13 '24 20:02 jrhemstad

/merge

PointKernel avatar Feb 21 '24 16:02 PointKernel