cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Use CubinLinker for CUDA Minor Version Compatibility

Open gmarkall opened this issue 3 years ago • 1 comments

Description

This switches to using CubinLinker (from PTXCompiler, but CubinLinker uses PTXCompiler internally) for Minor Version Compatibility. This enables support for all Numba features except linking archives with MVC, in support of use cases such as String UDFs (#11319) with MVC.

This temporarily uses packages from my channel, whilst I ensure that there are no issues with the CubinLinker packages using the CI for this PR.

Note: This PR uses packages from the numba channel for Numba 0.56.2. The use of this channel can be reverted, once Numba 0.56.2 is available from the conda-forge channel. As such, this PR presently has the "DO NOT MERGE" label.

Checklist

  • [X] I am familiar with the Contributing Guidelines.
  • [X] New or existing tests cover these changes.
  • [X] The documentation is up to date with these changes.

gmarkall avatar Sep 14 '22 10:09 gmarkall

CI errors related to :https://github.com/dask/dask/issues/9490

galipremsagar avatar Sep 14 '22 15:09 galipremsagar

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@4023b65). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 24918f7 differs from pull request most recent head c3c1973. Consider uploading reports for the commit c3c1973 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11701   +/-   ##
===============================================
  Coverage                ?   86.56%           
===============================================
  Files                   ?      133           
  Lines                   ?    21781           
  Branches                ?        0           
===============================================
  Hits                    ?    18855           
  Misses                  ?     2926           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 27 '22 00:09 codecov[bot]

Now that all the required packages are available in the usual channels (Numba 0.56.2 from conda-forge and CubinLinker from rapidsai) I've removed the "DO NOT MERGE" label. Additionally I've added some changes from Brandon that remove the checks on the driver / runtime versions for enabling string UDFs, as the changes in this branch mean that those checks should no longer be necessary.

Assuming the tests all pass this should be good for a review / merge if the review is OK.

gmarkall avatar Sep 28 '22 18:09 gmarkall

I opened an integration repo PR: https://github.com/rapidsai/integration/pull/535

galipremsagar avatar Sep 28 '22 18:09 galipremsagar

Thanks all! 🎉

jakirkham avatar Sep 29 '22 21:09 jakirkham