cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Sanitize percentile_approx() output for empty input

Open SrikarVanavasam opened this issue 3 years ago • 1 comments

Closes #10856

If all of the tdigest inputs to percentile_approx are empty, it will return a column containing null rows, as expected, but they will have unsanitary offsets. This PR checks if all the inputs are empty and returns an empty column as expected.

SrikarVanavasam avatar Aug 09 '22 15:08 SrikarVanavasam

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@039622f). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11498   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22852           
  Branches                ?        0           
===============================================
  Hits                    ?    19761           
  Misses                  ?     3091           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 17:08 codecov[bot]

@gpucibot merge

nvdbaranec avatar Aug 11 '22 18:08 nvdbaranec