cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Add fluent API builder to `data_profile`

Open vuule opened this issue 2 years ago • 1 comments

Description

Added a builder to enable complex initialization of data_profile objects. The builder slightly expands the API to make some common uses easier:

  • Setting distribution no longer requires passing a value range (default used to be passed in some benchmarks).
  • The special case where set_null_frequency(nullopt) is called to prevent the generator from materializing the null mask is now a more explicit call no_validity().

Updated the benchmarks to use the new builder. Setters are still used in places where data_profile object is modified and reused.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

vuule avatar Aug 05 '22 01:08 vuule

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@2be93fe). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11479   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22945           
  Branches                ?        0           
===============================================
  Hits                    ?    19816           
  Misses                  ?     3129           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 03:08 codecov[bot]

@gpucibot merge

vuule avatar Aug 12 '22 23:08 vuule