cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Refactor pad_side and strip_type enums into side_type enum

Open davidwendt opened this issue 3 years ago • 1 comments

Description

Refactors the cudf::strings::pad_side and cudf::strings::strip_type to a single enum cudf::strings::side_type. These have the same values as used by cudf::strings::pad and cudf::strings::strip Moving these into a single header helps with reusing them in the strings_udf work. Updates to gtests and cython code layers are also included.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

davidwendt avatar Aug 02 '22 19:08 davidwendt

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@e5b92df). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11438   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22949           
  Branches                ?        0           
===============================================
  Hits                    ?    19819           
  Misses                  ?     3130           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 00:08 codecov[bot]

This should be marked as a breaking change since the public enums have been moved/renamed.

davidwendt avatar Aug 12 '22 18:08 davidwendt

@gpucibot merge

davidwendt avatar Aug 16 '22 12:08 davidwendt