the rapidloop/pq fork causes a conflict when using the collector package

[philmcc]

trafficstars

Hi,

When using the collector package with other code that uses the lib/pq standard package, you get an error:

panic: sql: Register called twice for driver postgres

This is due to pgmetrics using the fork of lib/pq, rapidloop/pq.

Is it possible to change this to use the standard library so that it will work with other code?

Thanks

[mdevan]

This was done to support SCRAM-SHA-256 which was not available in lib/pq. Now that lib/pq also supports SCRAM-SHA-256, the fork is no longer needed and we should be going back to the upstream implementation.

So yes, will change it back to lib/pq soon.

[philmcc]

Thanks for letting me know. That will be awesome once it’s back in.

Thanks

On 3 May 2019, at 09:24, Mahadevan [email protected] wrote:

This was done to support SCRAM-SHA-256 which was not available in lib/pq. Now that lib/pq also supports SCRAM-SHA-256, the fork is no longer needed and we should be going back to the upstream implementation.

So yes, will change it back to lib/pq soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.