Test move logging to core

[adfoster-r7]

Extension of https://github.com/rapid7/metasploit-framework/pull/17495 Updating the Gemfile to pull in the gem to see if CI will pass

[sempervictus]

Already looking better than the bloodbath in mine, thank you.

[adfoster-r7]

Looks like it would cause breakages if we merged the rex-core/framework PR combo

  1) modules/payloads windows/meterpreter/reverse_https_proxy it should behave like payload cached size is consistent windows/meterpreter/reverse_https_proxy can load 'payload/stagers/windows/reverse_https_proxy'
     Failure/Error:
       log_sink ||= Rex::Logging::LogSinkFactory.new(
         log_sink_name,
         Msf::Config.log_directory + File::SEPARATOR + "framework.log"
       )

     NameError:
       uninitialized constant Rex::Logging::LogSinkFactory
       Did you mean?  LoginDataProxy

[sempervictus]

I updated the other side to explicitly require 'rex/logging' from core.rb to avoid reliance on auto-loading of dependencies. Lets see what it says after that change.

[adfoster-r7]

Looks like it hits the same issue; Probably worth checking out locally and verifying - but I think it'll require a few more requires/autoload definitions in rex-core/framework

[sempervictus]

Zeitwerk related - all the require statements were removed. Restored those.

[adfoster-r7]

@sempervictus Looks like that went green now; I'd prefer to land this after the 6.3 release though just to be sure there's no gremlins hiding 😄

Should be the next week or so for that

[sempervictus]

@adfoster-r7 - ping for liveness now that 6.3's been out a bit.

[adfoster-r7]

ping for liveness now that 6.3's been out a bit.

It's on the TODO list to check if there's an easy way to preserve history in a way that we'd expect, but it's still pretty far down on the TODO list

Is this migration impacting anything on your end? 👀

[sempervictus]

Doesn't impact my end, just keeps folks from using rex-socket stag without Msf :). Can we have the code live in both repos until the git thing's figured out? That way users can grab Rex gems for their use while Msf keeps git history on this. Even if Zeitwerk reloads it for some reason... its identical code :)

[adfoster-r7]

Will close this off to keep the PR queue tidy; it looks like there's more work required in other places to actually wire this up correctly (context) - regardless of preserving Git history :+1:

[github-actions[bot]]

Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it attic and closed it for now.

What does this generally mean? It could be one or more of several things:

• It doesn't look like there has been any activity on this pull request in a while
• We may not have the proper access or equipment to test this pull request, or the contributor doesn't have time to work on it right now.
• Sometimes the implementation isn't quite right and a different approach is necessary.

We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this!