Metasploit companion for rex-core #32

[sempervictus]

trafficstars

Using Rex' various gems without Msf will result in errors when the logging subsystem is undefined (as that remained in Msf during the great Rex excision). This manifests in rex-socket as noted by @zeroSteiner in rapid7/rex-socket#38.

Address the dependency problem by moving rex/logging into rex-core which is already required by rex-socket and other descendants.

Notes: This PR is staged to allow https://github.com/rapid7/rex-core/pull/32 to be merged without creating a (seemingly harmless) redundancy.

[sempervictus]

Those test failures are expected, i disemboweled logging in this commit until the testbeds have that rex-logging PR :smile:

[gwillcox-r7]

@sempervictus To clarify does this rely on https://github.com/rapid7/rex-core/pull/32 being merged first? Going to add a delayed tag for now under the assumption that is the case, but feel free to correct me if not.

[adfoster-r7]

Will close this off to keep the PR queue tidy; it looks like there's more work required in other places to actually wire this up correctly (context) - regardless of preserving Git history :+1:

Just for a paper trail: Cross-referencing the other test PR https://github.com/rapid7/metasploit-framework/pull/17506#issuecomment-1584889282 which I think had more of the missing pieces than this PR

[github-actions[bot]]

Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it attic and closed it for now.

What does this generally mean? It could be one or more of several things:

• It doesn't look like there has been any activity on this pull request in a while
• We may not have the proper access or equipment to test this pull request, or the contributor doesn't have time to work on it right now.
• Sometimes the implementation isn't quite right and a different approach is necessary.

We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this!