insightconnect-plugins icon indicating copy to clipboard operation
insightconnect-plugins copied to clipboard

Initial Commit - Luminar Threat intelligence

Open RamboV opened this issue 4 months ago • 1 comments

Proposed Changes

Description

Describe the proposed changes:

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

Review our documentation on generating and writing plugin unit tests

  • [ ] Unit tests written for any new or updated code

In-Product Tests

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

  • [ ] Screenshot of job output with the plugin changes
  • [ ] Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

  • [ ] For dependencies, pin OS package and Python package versions
  • [ ] For security, set least privileged account with USER nobody in the Dockerfile when possible
  • [ ] For size, use the slim SDK images when possible: rapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num} and rapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
  • [ ] For error handling, use of PluginException and ConnectionTestException
  • [ ] For logging, use self.logger
  • [ ] For docs, use changelog style
  • [ ] For docs, validate markdown with insight-plugin validate which calls icon_validate to lint help.md

Functional Checklist

  • [ ] Work fully completed
  • [ ] Functional
    • [ ] Any new actions/triggers include JSON test files in the tests/ directory created with insight-plugin samples
    • [ ] Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • [ ] Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • [ ] Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -T tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run -T all --debug --jq (use PR format at end)
    • [ ] Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -R tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run --debug --jq (use PR format at end)

Assessment

You must validate your work to reviewers:

  1. Run insight-plugin validate and make sure everything passes
  2. Run the assessment tool: insight-plugin run -A. For single action validation: insight-plugin run tests/{file}.json -A
  3. Copy (insight-plugin ... | pbcopy) and paste the output in a new post on this PR
  4. Add required screenshots from the In-Product Tests section

[WIP]

RamboV avatar Sep 10 '25 12:09 RamboV

:white_check_mark: Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
:white_check_mark: Open Source Security 0 0 0 0 0 issues
:white_check_mark: Licenses 0 0 0 0 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

simonirwin-r7 avatar Sep 10 '25 12:09 simonirwin-r7

Hello @simonirwin-r7 @igorski-r7 @mrinehart-r7 @mberezin-r7 @r7-kszczepanskagorna @r7-mgorny Can you please review it and let know for any changes? Thanks!

RamboV avatar Nov 15 '25 12:11 RamboV