Raphaël Pinson
Raphaël Pinson
That is true, the lens has never really been properly documented. There's a few inline comments in the code, but nothing to generate online docs.
I think the feature is really interesting, and would solve a lot of issues (although I'd be more in favor of eventually providing an API exposing the deleted elements so...
Do all the tests pass if you change the default behavior? Also, does it make sense to keep `seq` entries with region lenses, or could we just get back to...
There seems to be two issues here: 1. the eol-comment on the first line 2. the `Match all` rule
I don't know why exactly, but this type of constructs require two separate subtrees: ```augeas module A = let lns = [value "v" . del /a/ "a" ]| [value "w"...
This is unfortunately hard to fix while avoiding ambiguities. The current code reads: ``` augeas let entry = let some_value = Sep.space_equal . store to_comment_re (* Avoid ambiguity in tree...
@lutter that would be very useful. There are various format where a difference between empty value and no value would make sense.
I can try to throw an eye, probably not soon though.
LGTM, but I'd like @lutter and @georgehansper 's opinions
The TOML lens is kind of simplistic, partly because TOML is a complex format, with syntaxes are not simple (if at all possible) to model with Augeas. @msrd0 can you...