rio icon indicating copy to clipboard operation
rio copied to clipboard

Redrawing window when moving around split screens

Open Ruivalim opened this issue 1 year ago • 3 comments

So, basically what this is doing is when you move around the split screens, it will trigger a re-render so only the cursor of the current split you are in will be filled and all the other will be hollow. Making it easier to know which split you currently are.

Current behavior: image

New behavior: image

Ruivalim avatar Dec 23 '24 19:12 Ruivalim

Hey @Ruivalim thank you for the PR!

Isn't that working correctly? (At least it should be the default behaviour) Screenshot 2024-12-25 at 17 51 38

Lemme look the code changes

raphamorim avatar Dec 25 '24 20:12 raphamorim

aah ok, it's only for when you select next and prev using keybindings. I will think about the solution a bit more, I not a big fan of 2 sequenced render operations.

Btw, merry Christmas!

raphamorim avatar Dec 25 '24 20:12 raphamorim

Hello @raphamorim, I didn't like the two render calls either, but my thought was that the two renders won't be a problem because, normally, you won't be switching tabs too often.

Ruivalim avatar Dec 28 '24 20:12 Ruivalim

Sorry for late reply on this, I had to rewrite a lot of stuff on screen past month due to performance fixes. This commit should address the issue 🙏 https://github.com/raphamorim/rio/commit/d8b9080e4004e5b419ec5c07c142cad26b7f3299

raphamorim avatar May 05 '25 08:05 raphamorim

Will be closing this PR for now but anything can reopen, thank you for the contribution!!!

raphamorim avatar May 05 '25 08:05 raphamorim