rio icon indicating copy to clipboard operation
rio copied to clipboard

Show tab numbers in CollapsedTab layout

Open diwasrimal opened this issue 1 year ago • 3 comments

diwasrimal avatar Aug 14 '24 06:08 diwasrimal

That's great, thanks for the PR @diwasrimal. I haven't tested locally yet but I want to ask if is possible to add this feature behind a configuration property?

Maybe:

[navigation]
display-tab-number = true

raphamorim avatar Aug 14 '24 18:08 raphamorim

Other modes like TopTab, BottomTab and Breadcrumb already show tab numbers by default so I think you can just make it default to show numbering for CollapasedTab too. Using a single configuration variable like display-tab-number that handles showing number for all modes is good too. For me, this would take a lot of time since I'm not so comfortable with rust.

diwasrimal avatar Aug 15 '24 08:08 diwasrimal

Using a single configuration variable like display-tab-number that handles showing number for all modes is good too

yes, that’s what I meant, sorry if I wasn’t clear 🙏

The problem of implementing numbers for collapsed tabs by default is that many users like the way it’s (without much details) so might been conflicting with them as well.

For me, this would take a lot of time since I'm not so comfortable with rust.

there’s no rush! Take your time and feel free to ping me on discord as well. I can help pointing in the code 👌

raphamorim avatar Aug 15 '24 09:08 raphamorim