rio icon indicating copy to clipboard operation
rio copied to clipboard
verified publisher icon raphamorim

Support searching

Open dimitarvp opened this issue 2 years ago • 6 comments

Similar to iTerm2 and Alacritty, can we have Cmd-F / Ctrl-F and be able to search for a string? Is it deemed a desirable feature?

So far I am loving Rio, seems to need a bit more love still.

dimitarvp avatar Jul 29 '23 13:07 dimitarvp

Hey there @dimitarvp ,

Thanks for the issue. Yes searching is something I wanted to do since 0.0.6 but haven't prioritized it yet. I will move this issue to wishlist.

raphamorim avatar Aug 02 '23 08:08 raphamorim

+1 ❤️

tauil avatar Oct 13 '23 14:10 tauil

It will be a nice function -- currently a blocker for me.

cheney-yan-ifl avatar Jun 08 '24 02:06 cheney-yan-ifl

A very simple implementation (mvp) would satisfy most people, later the functionality could be improved ( similar to iterm2 / macOS Terminal).

image image

blackgwe avatar Jul 29 '24 08:07 blackgwe

maybe the mvp could be implemented in vi mode (/ search pattern ENTER") and n to find the next occurrence or N to find the previous.

blackgwe avatar Jul 29 '24 10:07 blackgwe

Since Rio uses Winit, it would be great to leverage if it offers some handy helper to perform the behavior suggested in the images above.

tauil avatar Jul 29 '24 10:07 tauil

FYI: For everyone on this issue/thread, I will be working on it now might be released in one of the upcoming versions. I am plan to do something similar to alacritty and wezterm (embedded on terminal content) since is easier to maintain compatibility through platforms

raphamorim avatar Aug 13 '24 08:08 raphamorim

Implemented an initial version in main branch, closing this issue. Any other improvement on search needs to create a different issue 🙏

Demo:

search

Thanks!

raphamorim avatar Aug 24 '24 17:08 raphamorim

Just updated my! Works like a charm! Thanks xará! 😄

tauil avatar Aug 26 '24 07:08 tauil