react-ape icon indicating copy to clipboard operation
react-ape copied to clipboard

Components: <Button/>

Open raphamorim opened this issue 5 years ago • 5 comments

Reference: https://facebook.github.io/react-native/docs/button

Description: Implement an initial version of Button component on React Ape renderer using Canvas.

AC: Consider using it on devices like TV and portable games.

raphamorim avatar Oct 25 '19 04:10 raphamorim

@raphamorim I can take a look at this issue!

hayanisaid avatar Jun 11 '22 21:06 hayanisaid

Sounds good, thank you @hayanisaid 👍 (Just a FYI: I am working in parallel in the navigation API)

raphamorim avatar Jun 12 '22 07:06 raphamorim

@raphamorim I have some questions about the Button component:

  • Should it add onPress, onClick, onFocus, onBluras props all together, or just enable an event based on the platform, but we don't have the Platform module yet.
  • I'm trying to make the button have an auto-layout, but I need to rely on the parentLayout {width,height} to got that done, do you know how this can be implemented? since the Flexbox is not implemented yet?

hayanisaid avatar Jun 17 '22 00:06 hayanisaid

Also, should I create another PR for the EventsHandling?

hayanisaid avatar Jun 17 '22 00:06 hayanisaid

I think for now let's start with small changes (will be better to review later), so would recommend start the onClick and be layout-dummy, for example: maybe render as similar behaviour as a Text, reading View parentLayout and rendering anywhere inside there

raphamorim avatar Jun 17 '22 09:06 raphamorim