react-ape icon indicating copy to clipboard operation
react-ape copied to clipboard

margin and padding for View

Open raphamorim opened this issue 3 years ago • 8 comments

Implementation of margin and padding for existent elements

raphamorim avatar Jun 08 '22 07:06 raphamorim

May, I take this issue?

Harshalyadav avatar Jun 08 '22 16:06 Harshalyadav

For sure, feel free to take it @Harshalyadav but please start with one, breaking in three PRs: image, text, view (the order you take doesn’t matter)

raphamorim avatar Jun 08 '22 19:06 raphamorim

@Harshalyadav I have broken into smaller issues (View, Text and Image). Later let me know which one want to work on, so I can assign the issue to you :)

raphamorim avatar Jun 09 '22 06:06 raphamorim

Could you give me more info about this issue?

Harshalyadav avatar Jun 09 '22 11:06 Harshalyadav

Yes, so the goal is to have the Style Props working for View. Both style props, margin and padding, follow React Native same directives and the work it works. Which is inspired by the way it works on CSS in Web browsers (https://blog.hubspot.com/website/css-margin-vs-padding).

  • Margin style prop definition: https://reactnative.dev/docs/layout-props#margin
  • Padding style prop definition: https://reactnative.dev/docs/layout-props#padding

raphamorim avatar Jun 09 '22 17:06 raphamorim

hey u distributed this issue among #118 #119 #120?

AAYUSH-droid avatar Jun 09 '22 17:06 AAYUSH-droid

yup @AAYUSH-droid

raphamorim avatar Jun 09 '22 18:06 raphamorim

@raphamorim, Thank you.

Harshalyadav avatar Jun 10 '22 16:06 Harshalyadav