pyKY040
pyKY040 copied to clipboard
Add initial position value
Thanks for the PR @Bcow7!
Is there a reason you got rid of this line ? If you don't use initial_pos
then you still would want it to be set to a default.
You are right. I missed the default value
My bad, that's on me — self.counter
is initialized to 0
at the instanciation. So you were right, you can get rid of the line.
Since your first commit I've added tests. Could you add a few lines for this new param? Also we need to assert self.initial_pos >= self.min_counter and self.initial_pos <= self.max_counter
in the lib, and your test would check that it is enforced. You can create a new test function I think, because anyway I need to add tests for all those type assertions.
If you don't have time for this I'll do it, just tell me! Sorry for those back-and-forth I'm kind of new to managing PRs ;)