Create a pre-release version for 0.7, because current example notebooks do not work with version 0.6.5
Hey,
I wanted to try some of the example notebooks, but they can not be run, since the newly introduced function fetch_sample is not yet released on the latest version available in pip. Is it possible for you to release something like a pre-release version 0.7 on pip, so the example notebooks can be run?
Also, I was not able to install the packge locally by cloning the repository using the given commands.
Thanks for your help!
Edit: I didnt realize the files are available in the repo for version 0.6.5. So the solution for now is to just use the notebook in that version
Thanks for flagging this! There are still some tasks remaining on the 0.7 roadmap but we should at least release a new minor version soon to fix the notebook. @remrama is there anything critical you wanted to push to main before I can release a 0.6.6 version?
Also, I was not able to install the packge locally by cloning the repository using the given commands.
What error did you get?
Agreed, thanks for catching this. @raphaelvallat I don't have anything else to add for a 0.6.6, this could be pushed immediately as far as I'm concerned.
@remrama there has been several big PRs since the 0.6.5 release, which I think justifies a bump to 0.7.0.
We could rename the current 0.7.0 roadmap to 1.0 and include the v0.7.dev changelog to the 0.7.0 release. Let me know what you think, thanks!
@raphaelvallat yes, that makes sense. I think it's reasonable to push 0.7 despite some goals still ahead.
Thanks for the answer!
Also, I was not able to install the packge locally by cloning the repository using the given commands.
What error did you get?
I basically just ran the provided commands. Here is what I did:
~/yasa# pip install ".[test]"
Processing /root/yasa
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
WARNING: unknown 0.0.0 does not provide the extra 'test'
Building wheels for collected packages: UNKNOWN
Building wheel for UNKNOWN (pyproject.toml) ... done
Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=1963 sha256=3cce71b32bb1eec8e2c6858f44c7788d6cb79c8bc59951ac7943731f3fcf5127
Stored in directory: /tmp/pip-ephem-wheel-cache-q0jyk3mu/wheels/1f/43/d1/8e2ded1184fa33301c9c8378a79b5e35104e02f9da3e699fc4
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
Attempting uninstall: UNKNOWN
Found existing installation: UNKNOWN 0.0.0
Uninstalling UNKNOWN-0.0.0:
Successfully uninstalled UNKNOWN-0.0.0
Successfully installed UNKNOWN-0.0.0
~/yasa# pytest
===================================================== test session starts =====================================================
platform linux -- Python 3.10.12, pytest-8.3.5, pluggy-1.5.0
rootdir: /root/yasa
configfile: pyproject.toml
plugins: cov-6.0.0
collected 0 items / 2 errors
=========================================================== ERRORS ============================================================
__________________________________________ ERROR collecting tests/test_detection.py ___________________________________________
ImportError while importing test module '/root/yasa/tests/test_detection.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/test_detection.py:21: in <module>
from yasa.fetchers import fetch_sample
E ModuleNotFoundError: No module named 'yasa.fetchers'
___________________________________________ ERROR collecting tests/test_fetchers.py ___________________________________________
ImportError while importing test module '/root/yasa/tests/test_fetchers.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/test_fetchers.py:7: in <module>
from yasa import fetchers
E ImportError: cannot import name 'fetchers' from 'yasa' (/usr/local/lib/python3.10/dist-packages/yasa/__init__.py)
=================================================== short test summary info ===================================================
ERROR tests/test_detection.py
ERROR tests/test_fetchers.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 2 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
===================================================== 2 errors in 20.84s ======================================================
@simonlet I'm not sure what is going on with the pytest error you've got. I just tried cloning the latest repo, installing with the same command as you, and running pytest, and it worked. I'm not sure what you're UNKNOWN and 0.0.0 is about. Are you pip installing from the top yasa directory (instead of the one under src)?
This sequence works fine for me with yasa-0.6.5 on platform win32 -- Python 3.12.3, pytest-8.3.5, pluggy-1.5.0:
git clone https://github.com/raphaelvallat/yasa.git
cd yasa
pip install ".[test]"
pytest