sublime-typescript icon indicating copy to clipboard operation
sublime-typescript copied to clipboard

Sublime Text 3 Support

Open Mpdreamz opened this issue 12 years ago • 10 comments

Hi @raph-amiard,

I really really wanted ST3 support, autocompletion and errors as you type is too good not to have, and saw in https://github.com/raph-amiard/sublime-typescript/issues/12 you had no plans to support ST3 so i had a stab at porting it over.

Issues I ran into:

  • reloading submodules needs to be explicit using reload() I wasted quite some time with stale submodules not being reloaded as i was developing.
  • running 2to3 was a breeze.
  • I am passing the current working dir to Popen() now as i was getting some rather obscure node errors due to a missing cwd argument.
  • stdin/out write readline is now bytes based.

You can leave this pull request open for a bit, it seems to mostly work for me on ST3 now though but I rather spent a few days with it and have others confirm the first time installation is still good on this branch.

Mpdreamz avatar May 12 '13 15:05 Mpdreamz

It seems the challenge is in supporting ST3 & ST2 simultaneously. There are some plugins that do, such as GoSublime.

nathany avatar May 12 '13 19:05 nathany

I have your code merged into my fork, and I'm not seeing any error highlighting or autocomplete (except for the standard ST autocomplete). I've never had it working though, is there something fancy I have to do locally to get it set up?

seanhess avatar May 25 '13 07:05 seanhess

No, its been flakey for me too. At the moment it keeps saying it can't find node eventhough all the paths seem to be in order.

Mpdreamz avatar May 29 '13 19:05 Mpdreamz

It would be so cool to get this actually working. I need to dig through your code and see what is going on.

seanhess avatar May 29 '13 21:05 seanhess

Yeah when I had it working like a charm it was a total bliss to work with :) Some more eyes on this is much appreciated

Mpdreamz avatar May 30 '13 13:05 Mpdreamz

Any ideas what isn't working? I don't really know how it works. Typescript provides a service, and you write an integration in the plugin somehow right? I've never seen sublime doing real autocomplete so I don't have any examples. 

​It's new with ST3 right? 

— Sent from Mailbox for iPhone

On Thu, May 30, 2013 at 7:30 AM, Martijn Laarman [email protected] wrote:

Yeah when I had it working like a charm it was a total bliss to work with :)

Reply to this email directly or view it on GitHub: https://github.com/raph-amiard/sublime-typescript/pull/16#issuecomment-18679981

seanhess avatar May 30 '13 16:05 seanhess

Loading of plugin-settings work asynchronous in ST3, which doesn't seem to be supported correctly in this plugin (in particular for install.py). That's at least one of the problems for now.

JasperH8g avatar Jul 05 '13 07:07 JasperH8g

I found https://github.com/Railk/T3S which works for me! (must install typescript-tools first, then restart sublime).

Consider linking to it in the readme?

seanhess avatar Sep 03 '13 19:09 seanhess

Please also refer to my fork here. https://github.com/seanhess/sublime-typescript - @raph-amiard seems to be ignoring messages from this repo. I've asked him to transfer ownership but he's not responding.

This repo supports very good inline error checking and syntax highlighting. No completions yet, but T3S has them. Should be coming soon to my fork too

seanhess avatar Sep 21 '13 16:09 seanhess

Also see https://github.com/Railk/T3S

nathany avatar Sep 21 '13 17:09 nathany