CamllVM icon indicating copy to clipboard operation
CamllVM copied to clipboard

c++0x and vmkit

Open jean-dao opened this issue 12 years ago • 6 comments

All vmkit source code does not use c++0x standard unlike Z3. I don't think we can manage to keep both as is and fix it automagically in the Makefile (Please prove me wrong!).

2 choices: we modify all of our headers or all of vmkit headers (yeah sure) to comply with only one standard.

jean-dao avatar Mar 31 '12 19:03 jean-dao

I don't understand where is the problem? Z3's makefiles and vmkit's makefile are totally unrelated... So you can add your prefered --std= in Z3's makefiles?

Gaël

2012/3/31 jean-dao [email protected]:

All vmkit source code does not use c++0x standard unlike Z3. I don't think we can manage to keep both as is and fix it automagically in the Makefile (Please prove me wrong!).

2 choices: we modify all of our headers or all of vmkit headers (yeah sure) to comply with only one standard.


Reply to this email directly or view it on GitHub: https://github.com/raph-amiard/Z3/issues/5


Gaël Thomas, Associate Professor, University of Pierre and Marie Curie Boite courrier 169, 217 - 26-00, REGAL Team, INRIA/LIP6, 4, place Jussieu, 75252 Paris Cedex 05, France Web: http://pagesperso-systeme.lip6.fr/Gael.Thomas/

Phone (mob): +33 6 10 39 31 17           Fax : +33 1 44 27 70 00

gaelthomas avatar Mar 31 '12 19:03 gaelthomas

Well in our code we have to include some vmkit headers which will be compiled with our makefile, so with our standard. I didn't manage to keep the c++0x standard and not having errors in vmkit headers.

But I am struggling with the makefile (trying to merge toyvm and Z3) so I may be doing something wrong...

jean-dao avatar Apr 01 '12 10:04 jean-dao

I don't understand either. Obviously Z3 is gonna include some of vmkit's headers, but that shouldn't be a problem since C++11 is compatible with C++98. That's a certainty. Are you sure the errors are related to the fact that we use the C++11 std ? If yes, could you post an example ?

raph-amiard avatar Apr 01 '12 10:04 raph-amiard

If this is really a problem though, it shouldn't be too hard to modify just the headers to be C++98 compliant. But i smell something fishy here :)

raph-amiard avatar Apr 01 '12 11:04 raph-amiard

Well I'm not sure of anything since I was playing around with the makefile to make it work. Anyway I ended modifying some of our headers (nothing much really) to make them C++98 compliant.

In fact I think this is a Makefile issue.

jean-dao avatar Apr 01 '12 11:04 jean-dao

Ok, I understand the pbm :)

You have two solutions. Either you can modify your files to be compliant with the standard used in vmkit, nor you can just define the standard before including vmkit's header. But I think that the second solution will not work...

Gaël

2012/4/1 jean-dao [email protected]:

Well I'm not sure of anything since I was playing around with the makefile to make it work. Anyway I ended modifying some of our headers (nothing much really) to make them C++98 compliant.

In fact I think this is a Makefile issue.


Reply to this email directly or view it on GitHub: https://github.com/raph-amiard/Z3/issues/5#issuecomment-4865767


Gaël Thomas, Associate Professor, University of Pierre and Marie Curie Boite courrier 169, 217 - 26-00, REGAL Team, INRIA/LIP6, 4, place Jussieu, 75252 Paris Cedex 05, France Web: http://pagesperso-systeme.lip6.fr/Gael.Thomas/

Phone (mob): +33 6 10 39 31 17           Fax : +33 1 44 27 70 00

gaelthomas avatar Apr 01 '12 14:04 gaelthomas