pg-anonymizer icon indicating copy to clipboard operation
pg-anonymizer copied to clipboard

Apply ESlint fixes

Open rap2hpoutre opened this issue 2 years ago • 3 comments

Currently, there is an incompatible mix between prettier default and ESlint. We should rely only on ESlint, and run lint on all files.

Side note: I have to wait for https://github.com/rap2hpoutre/pg-anonymizer/pull/13 to be merged to avoid conflicts

rap2hpoutre avatar Jan 02 '22 16:01 rap2hpoutre

I have time to work on this, but what do you run to get the ESlint output you prefer? npm run posttest ? And is eslintrc already to your liking?

imreACTmd avatar Jan 08 '22 13:01 imreACTmd

#13 has been merged, I could start on this.

imreACTmd avatar Jan 13 '22 13:01 imreACTmd

And is eslintrc already to your liking?

Not really! it's the default one provided by oclif since I used oclif to initialize the CLI (https://oclif.io/).

Most of the time, in my other projects, I only use Prettier with VS code without changing anything or adding something else. And when I use eslint, I prefer semicolons and more "default" conf.

In one of the products I develop currently with other devs (gov project), we choose this config and I feel like it's OK: https://github.com/betagouv/service-national-universel/blob/main/api/.eslintrc.js

Since you are currently the main contributor to this project 😅, it's also up to you. Feel free to suggest what you prefer too.

rap2hpoutre avatar Jan 31 '22 20:01 rap2hpoutre