laravel-log-viewer icon indicating copy to clipboard operation
laravel-log-viewer copied to clipboard

Better UX

Open ionesculiviucristian opened this issue 6 years ago • 9 comments

Consider moving the download/delete buttons up because on big files those are pretty impossible to use. That way I can cancel the page and have the buttons working without the need for scrolling. Cheers.

ionesculiviucristian avatar Jul 26 '18 15:07 ionesculiviucristian

Thank you for your contribution. AFAIK, there is only a few lines of logs displayed on each page, so it does not matter if the file is big or small: since there is a paginator, there is no need to scroll more than a bit to access this buttons. Did I missed something?

rap2hpoutre avatar Jul 30 '18 20:07 rap2hpoutre

I suppose he gets this from a low-resolution screen or small screen, can you confirm Lonescu ?

On Mon, Jul 30, 2018 at 4:45 PM Raphaël Huchet [email protected] wrote:

Thank you for your contribution. AFAIK, there is only a few lines of logs displayed on each page, so it does not matter if the file is big or small: since there is a paginator, there is no need to scroll more than a bit to access this buttons. Did I missed something?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rap2hpoutre/laravel-log-viewer/issues/163#issuecomment-409003922, or mute the thread https://github.com/notifications/unsubscribe-auth/ACXI_uUvYFy4yEIyOeGPNv9ccq5ECh1nks5uL3BNgaJpZM4ViFsU .

elminson avatar Jul 30 '18 21:07 elminson

I cannot use the buttons until the browser renders ALL of the entries and then shows the pagination. When there are many items it takes a while for the results to get "paginated".

ionesculiviucristian avatar Aug 03 '18 14:08 ionesculiviucristian

@ionesculiviucristian Can you upload a big log file to any services (Dropbox, google drive)?, I just want to test it and see if is possible just load the content by line (ex. from line 100 to 200 paginated by 10) and track the load timing and not load the complete file for a JSON result.

elminson avatar Aug 03 '18 16:08 elminson

You can generate a 10k file and see for yourself :D. I don't have any around right now.

ionesculiviucristian avatar Aug 09 '18 07:08 ionesculiviucristian

@ionesculiviucristian not sure why in your case have to wait until the browser renders ALL the entries. I imagine you need something like in the image, in my personal opinion I don't care to repeat this delete links in the top. What do you think @rap2hpoutre ? image

elminson avatar Aug 13 '18 21:08 elminson

@ionesculiviucristian I understand your problem, but I think I will not change anything (sorry about that). I will try to explain why below, feel free to answer.

Adding a line on the top of the page as suggested by @elminson could be a good solution but it make the UI more heavy IMO, and we could loose the "simplicity" of this package. One of my goal is to keep this package simple (in term of code, features and interface). So I try to limit the things directly visible on the page, in order to give users a quick view to the most relevant info (in this case, it's the log lines). With a list of not-so-useful buttons on the top on the page, only here to address a problem when there is too much logs, we risk penalizing all users that are not concerned by this need. My advice is to ...uh... wait for the whole page to load, then go to the bottom in this particular case 😅 (or maybe log less things)

BTW, sorry for the delay. Feel free to AMA.

rap2hpoutre avatar Aug 21 '18 22:08 rap2hpoutre

The idea was to quickly delete the log from the interface without having to wait for the DOM to fully load in order to have access to the functionality (aka buttons). I'll figure out something eventually. Anyway, thanks for the reply and for this great package :thumbsup:

ionesculiviucristian avatar Aug 28 '18 06:08 ionesculiviucristian

I think, this UX will improve via hacktoberfest? 👍 @rap2hpoutre

einnar82 avatar Oct 01 '18 14:10 einnar82