Mikko Koski

Results 25 comments of Mikko Koski

@ptaoussanis Thanks for coming back to the issue Yes, that sounds reasonable. I think it's a good idea to let the user decide what to do. I did some investigation...

> BTW I'm inclined to prefer O2 over O3 since O3 is coupled to the surrounding catching behaviour, which isn't within your control. O2 seems a more direct capture of...

What kind of support are you expecting? Some added type annotations?

Haha! 😂 Ok, thanks for pointing this out! I'll remove it.

Thanks for the workaround! The workaround seems to work fine when the "allOf defaults behaviour" is set to "Populate defaults with allOf"

Nice and clear bug report! I ran into this issue too. I investigated the source code a bit. The reason for the bug seems to be in this regex: https://github.com/noprompt/garden/blob/633785768136ed9b7338db60a4f14661ef44c453/src/garden/compiler.cljc#L176-L181...

I have a bit similar use-case. I'm using cheshire for pretty-printing JSON. So I'm reading the JSON from file and then using `parse-stream` and `generate-string` with pretty printing options, and...

Related: https://github.com/dakrone/cheshire/issues/73

We're facing exactly the same issue and exactly in the same conditions @s1rd4v3 described, i.e. `allOf` + `if/then/else` inside an array. Here's my [playground example](https://rjsf-team.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6e30sInNjaGVtYSI6eyJ0eXBlIjoib2JqZWN0IiwicHJvcGVydGllcyI6eyJzZWN0aW9uVHlwZSI6eyJ0eXBlIjoic3RyaW5nIiwiZW51bSI6WyJoZXJvIiwiY29sdW1ucyJdfSwiYmxvY2tzIjp7InR5cGUiOiJhcnJheSIsIml0ZW1zIjp7InR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7ImJ1dHRvblR5cGUiOnsidHlwZSI6InN0cmluZyIsImVudW0iOlsibm9uZSIsImludGVybmFsIiwiZXh0ZXJuYWwiXX19LCJhbGxPZiI6W3siaWYiOnsicHJvcGVydGllcyI6eyJidXR0b25UeXBlIjp7ImNvbnN0IjoiaW50ZXJuYWwifX0sInJlcXVpcmVkIjpbImJ1dHRvblR5cGUiXX0sInRoZW4iOnsicHJvcGVydGllcyI6eyJpbnRlcm5hbExpbmtVcmwiOnsidHlwZSI6InN0cmluZyJ9fX19LHsiaWYiOnsicHJvcGVydGllcyI6eyJidXR0b25UeXBlIjp7ImNvbnN0IjoiZXh0ZXJuYWwifX0sInJlcXVpcmVkIjpbImJ1dHRvblR5cGUiXX0sInRoZW4iOnsicHJvcGVydGllcyI6eyJleHRlcm5hbExpbmtVcmwiOnsidHlwZSI6InN0cmluZyJ9fX19XX19fSwiYWxsT2YiOlt7ImlmIjp7InByb3BlcnRpZXMiOnsic2VjdGlvblR5cGUiOnsiY29uc3QiOiJjb2x1bW5zIn19LCJyZXF1aXJlZCI6WyJzZWN0aW9uVHlwZSJdfSwidGhlbiI6eyJwcm9wZXJ0aWVzIjp7Im51bUNvbHVtbnMiOnsidHlwZSI6Im51bWJlciJ9fX19XX0sInVpU2NoZW1hIjp7fSwidGhlbWUiOiJkZWZhdWx0IiwibGl2ZVNldHRpbmdzIjp7InNob3dFcnJvckxpc3QiOiJ0b3AiLCJ2YWxpZGF0ZSI6ZmFsc2UsImRpc2FibGUiOmZhbHNlLCJyZWFkb25seSI6ZmFsc2UsIm9taXRFeHRyYURhdGEiOmZhbHNlLCJsaXZlT21pdCI6ZmFsc2V9fQ==) Steps to reproduce: 1. Open...