newsh icon indicating copy to clipboard operation
newsh copied to clipboard

Support vscode integrated terminal

Open nirnatan opened this issue 5 years ago • 6 comments
trafficstars

Is it possible to add support for vscode integrated terminal? Currently the command opens 'Terminal' process with the split command

nirnatan avatar Feb 23 '20 13:02 nirnatan

@nirnatan I couldn't find a way to do it yet. It needs some investigation.

I'll paste here issues that looks relevant:

Launch task directly into split terminal

How to run a script in a new Integrated Terminal window from an Integrated Terminal window

Provide commands to split the terminal

We can maybe find a workaround using tasks API.

ranyitz avatar Feb 23 '20 14:02 ranyitz

/cc @tyriar who might have an idea

orta avatar Feb 24 '20 23:02 orta

There would need to be a CLI API to split the terminal which doesn't exists and I don't think has come up before. Additionally we don't allow splitting directionally currently, it just splits depending on the orientation of the terminal.

Tyriar avatar Feb 27 '20 15:02 Tyriar

Thanks @orta & @Tyriar!

Additionally we don't allow splitting directionally currently, it just splits depending on the orientation of the terminal

That makes sense to me.

There would need to be a CLI API to split the terminal which doesn't exists and I don't think has come up before

I would love to open an issue if you think that it would be relevant.


It seems that a similar API to the one suggested here is being developed on windows terminal. This can be handy for vscode's integrated terminal as well.

ranyitz avatar Mar 03 '20 21:03 ranyitz

@ranyitz yes could you open an in vscode to add a cli? I think it would have to be a subgroup like code terminal split-pane, not just code split-pane as it would pollute the top-level namespace too much. Please include the microsoft/terminal link.

Tyriar avatar Mar 04 '20 15:03 Tyriar

Thanks @Tyriar, issue opened - https://github.com/microsoft/vscode/issues/92031

ranyitz avatar Mar 04 '20 20:03 ranyitz