Radek Antoniuk

Results 163 comments of Radek Antoniuk

@corymhall I think I stumbled on this as well but I'm not sure that I agree with the solution. All my stacks are working fine on the local console using...

I have fixed the problem of the manual `cdk diff` in the pipeline, by adding the required IAM _sts:AssumeRole_ permissions: ``` { "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Action":...

@corymhall the action works flawlessly when I removed the custom credentials logic and disabled associated tests and tested via `uses: rantoniuk/corymhall-cdk-diff-action@use-default-credentials` In the commented PR I see _wrong_ warning: >...

@corymhall I agree about the unsupported case, but I fail to understand why would this action need to support anything at all instead of relying on the credentials provided in...

> This action is trying to mimic the behavior of the CDK CLI Is there any specific reason it does that instead of relying on CDK buil-in capabilities? After all,...

Unfortunately this does not answer my question at all. What you're describing is post-authentication logic and this whole discussion is about why the custom logic exists for authentication: https://github.com/corymhall/cdk-diff-action/blob/773b5ec3d64f5d871e83a4408f9d9d9d24c6bc94/src/diff.ts#L72-L83 I...

I just tested it and it seems it works flawlessly so I will now be able to drop my custom version when this gets released - great work! ``` -...

@copilot rebase this to resolve conflicts