Alexander Polyankin comments

Results 183 comments of


                                            Alexander Polyankin

Custom Column after aggregation causes dashboard filtering to be very limited

This is a limitation in the query processor, more details here https://metaboat.slack.com/archives/C052ZBWRG3W/p1683320074594969

Query fails when selecting two fields from nested query, when fields are identical except for their join-alias

The issue is much worse now. When following step 2 - selecting People table and joining with Q1 - the query builder breaks because of a CLJS exception:

Incorrect column names when using join on saved question with custom column

These column names come from QP and not MBQL lib

Date/DateTime sort works correctly on question but not on dashboard

It seems that FE-level sorting in dashboards is just broken by design. We cannot make it work. Some ideas how this can be handled: - Remove FE sorting from dashcards...

Add possibility to consistently get object property name

@matanlurey `if (changes.containsKey(nameof(field)) ...`.

Fix error on strong mode

Can you please send this PR to https://github.com/ranquild/uix?

Relative dates filter uses invalid date range

We call a MLv2 `formatRelativeDateRange` to format the date range now, so it's a BE bug if it still exists

Relative dates filter uses invalid date range

So the problem is that the FE uses a very low-level expression for relative datetime filters that doesn't work correctly. I think ideally we need to do this: 1. QP...

[BE] Combining metrics does not work (joining metrics and using a custom expression to combine the metrics in the aggregation clause)

@snoe there is no MBQL lib error I can reproduce, only QP: ``` { "status": "failed", "class": "class clojure.lang.ExceptionInfo", "error": "Error preprocessing query in metabase.query_processor.preprocess$ensure_pmbql$fn__64341@16b75197: null", "stacktrace": [ "--> query_processor.preprocess$preprocess$fn__64345$fn__64346.invoke(preprocess.clj:133)",...

[BE] Combining metrics does not work (joining metrics and using a custom expression to combine the metrics in the aggregation clause)

You can follow steps from this test https://github.com/metabase/metabase/blob/e3f0a67100aa0bc574ac671dae37af7b1ca03567/e2e/test/scenarios/metrics/metrics-creation.cy.spec.ts#L140